WordPress / WordPress/create-block-theme
Dimensions tab persistence
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 417
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
Part of #836. Wires the Dimensions tab to the existing endpoint. Depends on the Color/foundation PR (lifts modal-level state lifting and save UX into place).
Scope
Lift state for the four Dimensions panels to modal level and include their values in the payload sent by handleUpdateClick:
LayoutPanel→settings.layout.*SpacingSettingsPanel→settings.spacing.*(flag fields)SpacingPresetsPanel→settings.spacing.spacingSizesSpacingUnitsPanel→settings.spacing.units
Acceptance criteria
- Each Dimensions sub-panel's edits persist on Update.
- Loading / success / error UX matches Color tab.
- No regression to Color persistence.
Out of scope
- Other tabs.
References
- Tracking issue: #836
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the four named panels—LayoutPanel, SpacingSettingsPanel, SpacingPresetsPanel, and SpacingUnitsPanel—and the modal's handleUpdateClick payload. Review the Color tab and the dependency described in #836 for the expected loading, success, and error UX. Done means all Dimensions edits persist on Update without regressing Color persistence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100