WordPress / WordPress/create-block-theme
Not allowed "theme" property added to settings.spacing.spacingScale
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 417
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
If a spacing scale is defined in settings.spacing.spacingScale and if the user saves its theme to files from the site editor, a theme property is added to spacingScale as a child. It does not break the theme but the property is not allowed by schema ("Property theme is not allowed.").
Identified bug:
"spacingScale": {
"theme": {
"increment": 16,
"mediumStep": 32,
"operator": "+",
"steps": 7,
"unit": "px"
}
},
Should be:
"spacingScale": {
"increment": 16,
"mediumStep": 32,
"operator": "+",
"steps": 7,
"unit": "px"
},
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce saving a theme with a spacing scale from the site editor, then trace how settings.spacing.spacingScale is serialized into theme files. Done means the saved spacingScale contains increment, mediumStep, operator, steps, and unit directly, without a nested theme property, and passes schema validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100