WordPress / WordPress/create-block-theme
Improve the CBT_Theme_Fonts class tests
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 417
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
What?
Simplify the CBT_Theme_Fonts class tests.
- Try to make the tests more granular and simple.
- Make the tests follow core guidelines.
- Avoid manual operations to manipulate or create themes inside the test cases. Example:
https://github.com/WordPress/create-block-theme/blob/128d363fe17b4187bec80f1fe8ba188966e51d8f/tests/test-theme-fonts.php#L27-L41
Why?
- Make the tests more effective for testing the class methods.
- Make the tests easier to understand, maintain, and update.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading tests/test-theme-fonts.php and the CBT_Theme_Fonts class tests it contains. Identify the manual theme creation or manipulation in the test cases, then make the tests more granular and aligned with core guidelines; done means the class methods are tested clearly without those manual operations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100