WordPress / WordPress/create-block-theme
Modified default font size presets are not added to the resulting theme.json
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 417
- Forks
- 66
- PR merge metrics
- No merged PRs in 30d
Description
What?
Let's say you created a blank theme and modified the default font sizes to create your theme. If you save the theme, you expect those changes to be saved, but that isn't the case. The changes to the default font sizes are not saved in the theme.json, and the settings have been removed, so those changes are lost.
Expected
If the default font sizes were changed, they should be added to the theme.json file when the user saves, exports, or creates style variations.
Reproduction steps:
- Create a blank theme
- Edit the default font size presets.
- Save changes to the theme. You will see that the edited font sizes are not present in the resulting theme.json file and the default font sizes were reset to the default.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the save, export, and style-variation paths that produce the resulting theme.json. Reproduce the issue with a blank theme and modified default font size presets, then verify that changed presets are retained in theme.json and are not reset after saving.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100