WordPress / WordPress/contributor-toolkit

First build runs the full production build when a dev build would do; a crashed build still counts as built

Open
#92 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area: build-install next-validation performance post-v1.0
Dominant language
JavaScript
Stars
36
Forks
13
Avg merge
23h 19m
Merged PRs (30d)
72

Description

What happens

The wizard's "Run first full build" step runs the full production build — minification, RTL generation, the works (src/renderer/index.jsx:1483-1492, and again in the dev-server start path at :1320). The dev server only needs a loadable build directory; the dev build produces that in a fraction of the time and its script is already on the terminal's allowlist.

On a Contributor Day laptop this step is measured in tens of minutes; nobody's first contribution needs minified core.

Related gap

The "has this site been built" check that decides whether a build is needed is existence-only — it checks that a build output directory exists (src/main.js:411-412). A build that crashed or was killed partway still counts as built, so the server starts against a half-built tree and the wizard reports the build complete. A completion marker written only on a successful exit would make the signal honest.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with src/renderer/index.jsx:1320 and 1483-1492 to trace the first-build and dev-server paths, then inspect src/main.js:411-412 for the existence-only build check. Verify the wizard uses the faster dev build and that only a successfully completed build is reported as ready, including after a crashed or interrupted build.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.