WordPress / WordPress/WordPress-Coding-Standards
Include rawurlencode() in list of sanitizing functions
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
I have some code like so:
$data['host'] = isset( $_SERVER['HTTP_HOST'] ) ? rawurlencode( sanitize_text_field( wp_unslash( $_SERVER['HTTP_HOST'] ) ) ) : ''; // input var ok
@mjangda informs me the sanitize_text_field() and wp_unslash() calls are unnecessary and rawurlencode() should be enough to make the data safe.
Currently, removing them results in a WordPress.VIP.ValidatedSanitizedInput.InputNotSanitized error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the PHP_CodeSniffer rule that reports WordPress.VIP.ValidatedSanitizedInput.InputNotSanitized and its list of recognized sanitizing functions. Add rawurlencode() to the appropriate coverage and create or update a regression test for the shown HTTP_HOST usage. Run the relevant sniff test suite and confirm the warning is no longer reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- security, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100