WordPress / WordPress/WordPress-Coding-Standards
NonceVerification overzealous ?
Open
Nobody has claimed this yet.
Focus: Security
Type: Bug
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
The following snippet of code triggers the WordPress.CSRF.NonceVerification sniff.
if ( ! isset( $_POST['field'] ) ) {
// Do something (not using the post variable).
}
As this is checking whether a variable is not set, I believe that the error is thrown erroneously.
Opinions ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the WordPress.CSRF.NonceVerification sniff and reproduce the reported PHP snippet. Trace why an isset() check on an unused POST field is flagged, then add or update coverage for this case. Done means the snippet no longer produces an erroneous warning while genuine nonce-verification violations remain reported.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100