WordPress / WordPress/WordPress-Coding-Standards
Add arithmetic bracketing sniff ?
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
As operator precedence is a mystery to a lot of programmers, demanding brackets around arithmetics is good practice and prevents bugs.
So, should we add it ? Squiz.Formatting.OperatorBracket.MissingBrackets does the trick.
Optionally this sniff could be forked to throw a warning instead of an error.
As it's not in the handbook, should probably go in extra.
Opinions ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the existing Squiz.Formatting.OperatorBracket.MissingBrackets sniff and the issue discussion. Determine whether the rule belongs in the extra ruleset and whether warning behavior is required. Done means the scope and behavior are agreed and the corresponding WordPress coding-standard rule is implemented and documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100