WordPress / WordPress/WordPress-Coding-Standards

Add a lint for strpos === 0 to use str_starts_with

Open
#2,262 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Component: Core Focus: Modern PHP Upstream: PHPCSExtra
Dominant language
PHP
Stars
2.8k
Forks
521
Avg merge
5d 20h
Merged PRs (30d)
1

Description

Is your feature request related to a problem?

Describe the solution you'd like

Add a lint for strpos === 0 to use str_starts_with and the opposite. See hhttps://core.trac.wordpress.org/changeset/55703. str_starts_with is a php 8.0 function but a polyfill was added in core in WP 5.9. https://github.com/WordPress/wordpress-develop/commit/1046682e4f2453c55f836b3fe69f529daea0babc

Additional context (optional)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by locating the existing WordPress-Coding-Standards sniffs and their tests for strpos comparisons, then review the referenced WordPress changeset and polyfill context. Done means the lint covers strpos === 0 and the opposite case according to the requested str_starts_with replacement.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
devtools
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.