WordPress / WordPress/WordPress-Coding-Standards
array_filter with is_numeric, is_int, is_float should sanitize
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
$ids = array_filter( $_POST['ids'], 'is_numeric' );
Even without wp_unslash (shouldn't report an error either)
Same when using is_int or is_float as callback
Probably fix is similar to https://github.com/WordPress/WordPress-Coding-Standards/pull/1679
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported array_filter example with is_numeric, is_int, and is_float as callbacks, and compare the expected behavior with the approach in pull request #1679. The issue is done when these callback forms no longer produce an incorrect sanitization report, including the case without wp_unslash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100