WordPress / WordPress/WordPress-Coding-Standards
Treat `ceil()`, `floor()`, and `round()` as safe for output
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
Is your feature request related to a problem?
When outputting a numeric value as an integer, the absint() and intval() functions are treated as safe for output by WPCS. The same is not true for ceil(), floor(), and round().
Describe the solution you'd like
The ceil(), floor(), and round() functions should be added to the Sniff:$escapingFunctions property.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Sniff class and its $escapingFunctions property, then inspect the surrounding escaping logic and any related tests. Add ceil(), floor(), and round() to the safe-function handling, and confirm the existing output-escaping tests cover these functions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100