WordPress / WordPress/WordPress-Coding-Standards
Warn if running a query without LIMIT
Open
Nobody has claimed this yet.
Focus: DB
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
Is your feature request related to a problem?
Especially for ERP functionality, which extends WooCommerce, direct db queries are used often instead of the WP API calls (options,...).
It would be nice if we could warn if we have a wpdb query that has no LIMIT set, just like it exists for the posts_per_page -1.
Describe the solution you'd like
like the sniff for posts_per_page missing or -1
$wpdb->get_results( $wpdb->prepare( "SELECT * FROM {$wpdb->prefix}some_table WHERE my_column like %s ), $some_var );
=> should require a LIMIT
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the existing sniff for missing or -1 posts_per_page and its tests, then inspect how wpdb get_results() queries are detected. Done means a query like the example without a LIMIT produces a warning, with tests covering the warning behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100