WordPress / WordPress/WordPress-Coding-Standards
Flag when `checked()`, `selected()` etc should be used
Open
Nobody has claimed this yet.
Component: Extra
Focus: WP interoperability
Type: Enhancement
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
What about a sniff to warn about code which does not use the WP helper functions - checked(), selected(), disabled(), wp_readonly()- for these form attributes ?
<!-- This should be flagged. -->
<input id="<?php echo esc_attr( $field_id ); ?>"
name="<?php echo esc_attr( $field_name ); ?>" type="checkbox"
class="prefix_classname"
value="1" <?php echo ! empty( $current_value ) ? ' checked="checked"' : ''; ?> />
<!-- This should not be flagged. -->
<input type="checkbox" id="input_field_id" checked="checked"/>
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the issue's PHP examples and inspect the repository's existing sniff and test structure to find the appropriate extension point. Define coverage for checked(), selected(), disabled(), and wp_readonly() attributes, including the flagged and non-flagged cases shown; done requires tests for those examples and a passing test run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100