WordPress / WordPress/WordPress-Coding-Standards
Errors regarding usage of deprecated core functions are too strict in a context of a namespace
Open
Nobody has claimed this yet.
Focus: Modern PHP
Type: Bug
- Dominant language
- PHP
- Stars
- 2.8k
- Forks
- 521
- Avg merge
- 5d 20h
- Merged PRs (30d)
- 1
Description
In the following code
namespace dummy;
function get_settings() {
return 'settings';
}
echo get_settings();
You are going to get a notice about the usage of the deprecated function get_settings() although the one being called in this code is the "local" one.
Suggested solution, when in the context of a namespace look for the existence of a "\" before the deprecated function name.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the rule that reports deprecated core functions and its namespace-related tests; the issue does not name specific files or entry points. Reproduce the shown namespaced example, then verify that a local function is not reported while the deprecated global function still is.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100