WordPress / WordPress/Requests

Add SOCKS proxy support

Open
#96 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Extras Type: enhancement
Dominant language
PHP
Stars
3.6k
Forks
500
Avg merge
2d 21h
Merged PRs (30d)
5

Description

SOCKS proxies are not currently supported.

It looks like there's a couple of issues with this though:

  1. Testing will be a pain. We can handle this like the HTTP proxy support, by worrying about that later.
  2. Sockets doesn't support SOCKS natively, so we'll have to write our own handling for this (see HTTP_Request2's adapter for reference)

(Split from #95)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the existing HTTP proxy support and the HTTP_Request2 SOCKS5.php adapter linked in the issue. Determine how SOCKS handling should fit the library's proxy flow; done means SOCKS proxy requests work, with testing addressed as described by the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.