WordPress / WordPress/Requests
Requests_Cookie::domain_matches doesn't account for IPv6
Open
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 3.6k
- Forks
- 500
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 5
Description
The Requests_Cookie::domain_matches method checks that the domain is not an IPv4 address. Should it also check that it isn't an IPv6?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Requests_Cookie::domain_matches and reading its existing IPv4 handling. Check how the method behaves for IPv6 addresses and add focused coverage for the intended matching behavior; done means IPv6 inputs are handled consistently with the method's address checks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100