WordPress / WordPress/Requests

Requests and Buster

Open
#383 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.6k
Forks
500
Avg merge
2d 21h
Merged PRs (30d)
5

Description

I use Requests on Stretch (Php 7.0.33) fine but with Buster (PHP 7.3.14-1) I have the following issues (this is perhaps due to php version, I don't know)

  • Requests.php line 574 if ($options['auth'] !== false) {
    with Stretch, $options['auth'] is false when empty : OK
    but with Buster, $options['auth'] is null when empty

  • get method response is empty with error 204

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with Requests.php around line 574 and reproduce the reported behavior on the referenced PHP versions. Investigate why an empty auth option becomes null on Buster and why a GET response with HTTP 204 is empty; done means both behaviors are understood and corrected or documented with regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
api, backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.