WordPress / WordPress/Requests

Include request data in exceptions

Open
#272 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PHP
Stars
3.6k
Forks
500
Avg merge
2d 21h
Merged PRs (30d)
5

Description

https://core.trac.wordpress.org/ticket/40266 documents what seems a bug.

In some cases, hostnames are included in errors + sometimes they're missing.

Trying to debug problems with missing hostnames requires, hacking up code, injecting manual debug logic in various places.

An ugly solution.

Request that all errors returned by the Requests library always include a hostname for the related error.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the linked WordPress Trac ticket 40266 first, then trace the Requests library's error paths to compare cases where hostnames are present or missing. Done means every error returned for a related request includes its hostname, with coverage for the affected cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
backend, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.