WordPress / WordPress/Requests
Requests shouldn’t trigger a warning for GET requests with body
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 3.6k
- Forks
- 500
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 5
Description
See https://core.trac.wordpress.org/ticket/37618, https://core.trac.wordpress.org/ticket/37364 and https://wordpress.slack.com/archives/core/p1470825455002837.
It'd be nice if Requests didn't trigger a warning, but the usage is incorrect here.
— @rmccue
Given that Requests’ handling of GET requests with a body has been reported twice now, it seems like "It'd be nice if Requests didn't trigger a warning” should be upgraded to “Requests shouldn’t trigger a warning”.
It should probably sanitise the request. Just remove the body, and trigger a notice.
— @pento
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the linked Trac tickets and Slack discussion first to understand the existing GET-with-body behavior and the requested warning semantics. Done means GET requests with a body are sanitized by removing the body and emitting a notice, with coverage for that behavior in the relevant test suite.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100