WillCodeForCats / WillCodeForCats/solaredge-modbus-multi

Please add a consumption above zero check in the template sensor

Open Beginner friendly
#1,079 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
326
Forks
29
Avg merge
1d 3h
Merged PRs (30d)
20

Description

Describe the feature
Hi,

would you mind adding a "only positive numbers" check into the "consumption" template sensor as you did with the "production" sensor? I am having all the fluctuations, see screenshot, and i am not proficient enough to mess around with the math in the sensor.

Screenshots

Image

Home Assistant (please complete the following information):

  • Home Assistant Core Version: current
  • solaredge-modbus-multi Version: current

Additional context
Add any other context about the request here.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the template sensor definitions and the existing production sensor logic that applies an "only positive numbers" check. Apply the equivalent behavior to the consumption sensor, then verify that fluctuating negative consumption values are excluded while valid positive readings remain. Confirm the integration's relevant sensor tests or normal validation pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.