WikiExtractor / WikiExtractor/wikiextractor

the function dropNested

Open
#248 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
4k
Forks
1k
Avg merge
1m
Merged PRs (30d)
10

Description

Hi please look at this line

https://github.com/attardi/wikiextractor/blob/6490f5361d7658208ad7f8e5deeb56ee0fe9e02f/wikiextractor/extract.py#L316

shouldn't it be while end.end() <= next.start(): instead of while end.end() < next.start():?

I think here the true condition is that } is before {. However, currently it means } is before { and there are some characters between them.

Am I misunderstanding?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open wikiextractor/extract.py at line 316 and read the dropNested function around the linked condition. Check how adjacent closing and opening matches are handled, especially when they meet directly. Done means the comparison reflects the intended boundary behavior and the relevant extraction behavior remains correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli, tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.