WerWolv / WerWolv/PatternLanguage
String + struct = segfault
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 275
- Forks
- 75
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 10
Description
The pattern language (both ImHex and the browser playground) will segfault upon running the following code:
struct A {};
A a;
str b = "" + a;
I debugged this a little bit, and it looks like the issue is in Pattern::getValue(). The clone() call creates a unique_ptr, which is freed when the function is done, but its pointer is left in the returned value, which is no longer valid.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Pattern::getValue() and reproduce the failure with the provided struct and string-concatenation example in ImHex or the browser playground. Trace the cloned unique_ptr and the returned value's pointer lifetime; done means the example no longer segfaults in both environments.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100