WebReflection / WebReflection/linkedom
Parsing fails and there is raw html code in rendered html
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 2.1k
- Forks
- 104
- PR merge metrics
- No merged PRs in 30d
Description
Hi there,
Parsing fails for some pages ( eg. this article )
To replicate, open the generated html in a browser
const document = (new DOMParser).parseFromString(htmlFromTheArticle, 'text/html');
const html = document.body.innerHTML;
Instead of the original page, it now includes raw html code.
Διαβάστε το πλήρες κείμενο του σημειώματος του CEO της UBS στο <a href="https://www.newmoney.gr/roh/bloomberg/to-esoteriko-simioma-tou-ceo-tis-ubs-pros-tous-ergazomenous-meta-tin-exagora-tis-credit-suisse/" target="_blank" rel="noopener noreferrer">newmoney.gr</a><br> <br> <strong><a href="https://www.protothema.gr/oles-oi-eidiseis/" target="_blank" rel="noopener noreferrer">Ειδήσεις σήμερα:</a><br> <br> <a href="https://www.protothema.gr/greece/article/1351532/xanthi-ston-eisaggelea-simera-o-36hronos-pou-skotose-ton-45hrono-epeidi-ton-theorise-roufiano/" target="_blank" rel="noopener noreferrer">...
It happened for many html documents already. The culprit is htmlparser2, if I downgrade to v6.1.0, it works properly.
I tried to debug and the problem is caused in Tokenizer.ts. When I simply replace these lines
if (this.isSpecial) {
this.state = State.InSpecialTag;
this.sequenceIndex = 0;
} else {
this.state = State.Text;
}
With
this.state = State.Text;
It works properly. I'm not sure what is the proper fix, which will not affect the performance of htmlparser2, so I opened this issue instead.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the linked article and the DOMParser example, then inspect Tokenizer.ts around the isSpecial state transition. Compare the current behavior with htmlparser2 v6.1.0 and verify that the rendered result no longer exposes escaped raw HTML while preserving parser performance and other special-tag handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- html, typescript
- Domain
- web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100