WebAssembly / WebAssembly/wasi-libc
Contradicting `SOL_TCP` and `SOL_UDP` definition for p1
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1k
- Forks
- 251
- Avg merge
- 7h 15m
- Merged PRs (30d)
- 3
Description
They are not defined within the p1 scope in libc-bottom-half/headers/public/__header_sys_socket.h:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/libc-bottom-half/headers/public/__header_sys_socket.h#L27-L28
But they are included in expected/wasm32-wasip1/predefined-macros.txt:
https://github.com/WebAssembly/wasi-libc/blob/0d5332aceea8e72698b6abc270550e666ba97aea/expected/wasm32-wasip1/predefined-macros.txt
Which one should be the source of truth?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the p1 declarations in libc-bottom-half/headers/public/__header_sys_socket.h with the entries in expected/wasm32-wasip1/predefined-macros.txt. First determine how the expected macro list is generated and which file defines the p1 contract. Done means resolving the source-of-truth question and making the two representations consistent, with the relevant macro-generation or validation checks passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Needs clarification
- Newbie friendliness
- 45/100