WebAssembly / WebAssembly/wabt
Inconsistent archive name for macos
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 8.1k
- Forks
- 827
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 18
Description
I noticed that the macos archive name in the release is inconsistent vs ubuntu/windows. It has the version name, -12 while the others don't. This is because the name is computed by stripping out the GHA runner name of -latest, but for macos the runner is not -latest
https://github.com/WebAssembly/wabt/blob/main/.github/actions/release-archive/action.yml#L16
https://github.com/WebAssembly/wabt/blob/main/.github/workflows/build.yml#L33
Presumably these are all supposed to be symmetric. One option to fix would be to switch to using lowercase of runner.os instead of matrix.os, that word contains Linux, MacOS, Windows. Note that it is linux instead of ubuntu, this would be a relatively significant change to the current name but perhaps it's a more appropriate one?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect .github/actions/release-archive/action.yml at line 16 and .github/workflows/build.yml at line 33 to compare how archive names are formed for each runner. Confirm the intended symmetric naming convention, then validate the resulting names in the release workflow for macOS, Ubuntu, and Windows.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions
- Domain
- build-system, ci-cd, release
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100