WebAssembly / WebAssembly/wabt
WastParser handling of `(module binary)` and `(module quote)`
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 8.1k
- Forks
- 827
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 18
Description
WastParser seems to:
- allow
(module binary "...")inParseModule(even though this is not valid syntax for the Wasm text format; it's only valid for scripts), and - forbid
(module quote "...")inParseScript, even though this is a valid script command. (It does allow(module quote)when inside(assert_malformed), which is the only thing the spec tests actually use.)
Not saying either of these edge cases is critical, but just documenting for the record. I think it would be nice to tighten up the first one since this seems like a possible avenue for mischief.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating WastParser's ParseModule and ParseScript entry points and inspect how module binary and module quote commands are parsed. Compare those paths with the script grammar and spec behavior; done means invalid module binary syntax is rejected while valid script module quote syntax is accepted, including appropriate parser coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100