WebAssembly / WebAssembly/wabt

wat2wasm internal corruption due to presence of functor type

Open
#2,098 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
8.1k
Forks
827
Avg merge
4d 6h
Merged PRs (30d)
18

Description

A function type which references another function type as a parameter type corrupts the internal state of wat2wasm, causing type lookup to fail, apparently returning (-1 / 0xffffffff / 4294967295) internally. The module and output are included below. This happens both with the current HEAD of the main branch and with the package version for Ubuntu 20.04. Removing the line that defines $T2 alllows wat2wasm to complete successfully.

Module:

(module

 (type $T1 (func (result i32)))
 (type $T2 (func (param (ref $T1)) (result i32)))

 (func (param $f (ref $T1)) (result i32)
   (call_ref (local.get $f))))

Output follows:

pat@quercus:~/src/crack$ wat2wasm --enable-function-references scratch2.wat -o scratch2.wasm
scratch2.wat:7:5: error: function type variable out of range: 4294967295 (max 2)
   (call_ref (local.get $f))
    ^^^^^^^^
scratch2.wat:7:5: error: type mismatch in implicit return, expected [i32] but got []
   (call_ref (local.get $f))
    ^^^^^^^^

pat@quercus:~/src/crack$ wat2wasm --version
1.0.27

pat@quercus:~/src/crack$ ../wabt/bin/wat2wasm --enable-function-references scratch2.wat -o scratch2.wasm
scratch2.wat:7:5: error: function type variable out of range: 4294967295 (max 2)
   (call_ref (local.get $f))
    ^^^^^^^^
scratch2.wat:7:5: error: type mismatch in implicit return, expected [i32] but got []
   (call_ref (local.get $f))))
    ^^^^^^^^

pat@quercus:~/src/crack$ ../wabt/bin/wat2wasm --version
1.0.31 (git~1.0.31-22-ged0b720c)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with the provided scratch2.wat module using wat2wasm and --enable-function-references. Trace the function-type lookup involved in call_ref and the nested functor type, then verify that the module compiles without the out-of-range type and follow-on type-mismatch errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, wasm
Domain
compilers, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.