WebAssembly / WebAssembly/wabt
There should be more tests for --enable- and --disable-
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 8.1k
- Forks
- 827
- Avg merge
- 4d 6h
- Merged PRs (30d)
- 18
Description
Currently it seems these are the only tests that test --disable-:
- https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/atomic-disabled.txt
- https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/bulk-memory-disabled.txt
- https://github.com/WebAssembly/wabt/blob/1f3a1d5fae0296fdf503968131905be9e8f40cf4/test/parse/expr/tail-call-disabled.txt
- https://github.com/WebAssembly/wabt/blob/30c1e983d30b33a8004b39fd60cbd64477a7956c/test/parse/module/reference-types-disabled.txt
It might be a good idea to add more of these, and make sure they apply to all the other tools, like wasm2c, too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the existing test/parse/expr/*-disabled.txt files named in the issue and locating other --enable- and --disable- test coverage. Run the relevant tool tests, including wasm2c, and add coverage for the remaining flags and tools; done means each applicable option is tested consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- cli, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100