WebAssembly / WebAssembly/wabt

Fix Various TODOs

Open
#1,375 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

good-first-bug
Dominant language
C++
Stars
8.1k
Forks
827
Avg merge
4d 6h
Merged PRs (30d)
18

Description

There are other TODOs in the source, but most of these should be small.

  • Update output from "type" to "func_type" TODO TODO
  • Rename LoadStoreExpr (maybe MemoryAccessExpr?) TODO TODO
  • Use proper location in binary-reader-interp.cc TODO
  • Implement event matching in interpreter TODO
  • Clean up "out of bounds" memory/table access messages TODO
  • Use u16 for SerializedOpcode in interpreter TODO
  • Move TypeChecker into SharedValidator TODO TODO
  • Change assert_unlinkable to a single-line error TODO
  • Print assert_uninstantiable and assert_exhaustion errors when assertion passes TODO TODO
  • Validate command-line arguments for value-stack-size and call-stack-size TODO TODO TODO TODO
  • Fix typo "initializing" TODO
  • Remove ParseTextList, switch usage to ParseTextListOpt TODO TODO

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked TODO locations in the listed source files, especially the interpreter, validator, spectest-interp, and wast-parser code. Determine which unchecked TODOs are still applicable and whether they can be handled independently. Done means the selected TODOs are resolved and the corresponding source behavior or naming matches the issue description.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, wasm
Domain
compilers, devtools
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.