WebAssembly / WebAssembly/binaryen
Most lit/help tests fail with new python-filecheck
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
In binaryen lit tests, filecheck is used to test the --help output of various wasm* tools.
With filecheck-0.0.24, the following test passes:
$ wasm-shell --help | filecheck help/wasm-shell.test
$
However, with filecheck-1.0.3 from the new upstream repo, it fails:
$ wasm-shell --help | filecheck help/wasm-shell.test
help/wasm-shell.test:4:9 found empty check string with prefix 'NEXT:'
;; CHECK-NEXT:
^
$
New upstream says the new behaviour is closer to the original filecheck and recommends using CHECK-EMPTY instead of CHECK-NEXT.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in test/lit/help, where the wasm* help-output tests use FileCheck directives. Run the wasm-shell example with filecheck 1.0.3, then inspect the other lit/help tests for empty CHECK-NEXT directives. Done means the affected help tests pass with the new upstream FileCheck behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- Half a day
- Activity status
- Active
- Clarity
- Clearly specified
- Newbie friendliness
- 76/100