WebAssembly / WebAssembly/binaryen
[wasm2c] Migrate to binaryen's existing hasher
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
For ease of validation, the initial version of wasm2c is using sha256 (via picosha2) for hashing. This issue tracks migrating to binaryen's existing hasher. This will cause output divergence, which is why we're doing it later.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the wasm2c hashing implementation and binaryen's existing hasher, then compare how each is used. Migrate wasm2c to the existing hasher and verify that the resulting output divergence is expected and consistently produced.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100