WebAssembly / WebAssembly/binaryen

Test suite failures on test/validator/invalid_import.wast and test/validator/invalid_export.wast

Open
#782 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
WebAssembly
Stars
8.6k
Forks
885
Avg merge
1d 19h
Merged PRs (30d)
69

Description

Running the test suite on OS X (log), Linux (log) and Windows, they all fail with the following errors:

1229 executing:  /home/clb/slaves/emslave/buildslave/ubuntu-incoming/emsdk/binaryen/master_64bit_binaryen/bin/wasm-as --validate=web /home/clb/slaves/emslave/buildslave/ubuntu-incoming/emsdk/binaryen/master/test/validator/invalid_export.wast
1230 [wasm-validator error in module] 2 == 2: Exported function must not have i64 return type, on 
1231 $export64
1232 (module
1233   (type $0 (func (result i64)))
1234   (memory $0 0)
1235   (export "a" (func $export64))
1236   (func $export64 (type $0) (result i64)
1237     (i64.const 1)
1238   )
1239 )
1240 Fatal: Error: input module is not valid.
1241 
1242 executing:  /home/clb/slaves/emslave/buildslave/ubuntu-incoming/emsdk/binaryen/master_64bit_binaryen/bin/wasm-as --validate=web /home/clb/slaves/emslave/buildslave/ubuntu-incoming/emsdk/binaryen/master/test/validator/invalid_import.wast
1243 [wasm-validator error in module] 2 == 2: Imported function must not have i64 parameters, on 
1244 $bad
1245 (module
1246   (type $FUNCSIG$vj (func (param i64)))
1247   (import "test" "bad" (func $bad (param i64)))
1248   (memory $0 0)
1249 )
1250 Fatal: Error: input module is not valid.
1251

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failures for test/validator/invalid_import.wast and test/validator/invalid_export.wast with the test suite. Read the reported validator errors and compare them with the expected behavior for imported parameters and exported results. Done means the validator tests complete successfully on the affected platforms.

Written by the indexing model from the issue text.

Assessment

Tech stack
wasm
Domain
compilers, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.