WebAssembly / WebAssembly/binaryen
[Emitting Zero] [Local Tracking] General rule might not handle unary ne emitting zero bits well
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Given the following code:
(module
(import "External" "external_function" (func $external_function))
(func $foo (result i32)
i32.const 0
i32.load)
(func $_start (param $0 i32) (param $1 i64) (param $2 i32)
(local $3 i32) (local $4 i32) (local $5 i32) (local $6 i32) (local $7 i32) (local $9 i32)
call $foo
local.set $4
i32.const 1
local.set $3
local.get $4
local.get $3
i32.shl
i32.const 1
i32.shr_s
local.set $6
i32.const 0
i32.const 0
i32.store
i32.const -259031342
local.set $7
local.get $6
local.get $7
i32.ne
local.set $9
block ;; label = @1
local.get $9
i32.eqz
br_if 0 (;@1;)
unreachable
end
call $bar)
(func $bar call $external_function)
(memory $0 258 258)
(export "_start" (func $_start)))
wasm-opt (755a8d0e) should deduce the condition to false, thus fold the branch to unreachable (further deleting call $bar), which works under -O2 but fails under -O3.
Below is optimized by -all -O3:
(func $_start (type $1) (param $0 i32) (param $1 i64) (param $2 i32)
(local.set $0
(i32.shr_s
(i32.shl
(i32.load
(i32.const 0)
)
(i32.const 1)
)
(i32.const 1)
)
)
(i32.store
(i32.const 0)
(i32.const 0)
)
(if
(i32.ne
(local.get $0)
(i32.const -259031342)
)
(then
(unreachable)
)
)
(call $external_function)
)
As you can see, the condition here
(i32.ne
(local.get $0)
(i32.const -259031342)
)
is not deduced to true.
Similar to #7492, Maybe there a missing rule for it to emit zero bits, or is the local tracking insufficient?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the supplied WebAssembly module through wasm-opt at commit 755a8d0e with -O2 and -all -O3, then compare the optimization results. Trace the handling of local tracking and unary comparisons, using issue #7492 as related context. Done means the condition is deduced as true and the branch becomes unreachable under -O3 as well.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100