WebAssembly / WebAssembly/binaryen

[Outlining] Simplify `filter` with a single call

Open
#6,114 0 comments 0 reactions 1 assignee View on GitHub

@ashleynh is already working on this.

Since Nov 13, 2023.

Dominant language
WebAssembly
Stars
8.6k
Forks
885
Avg merge
1d 19h
Merged PRs (30d)
69

Description

          It might be simpler to just call `filter` once from `Outlining::run` and pass it a lambda that contains all the various filters. I don't feel strongly, though. The current code is certainly very readable.

Originally posted by @tlively in https://github.com/WebAssembly/binaryen/pull/6110#discussion_r1390310084

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.