WebAssembly / WebAssembly/binaryen
Add comments to multi-memories tests
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Comments in these tests would be good, like without an explicit name, the first memory is used in this one, etc.
Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r946938904
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the Binaryen repository for the multi-memories tests referenced by the issue and read the existing test cases first. Add comments explaining the behavior each case covers, including the unnamed-memory lookup example; the work is done when the relevant tests clearly describe their scenarios without changing test behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers, testing
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100