WebAssembly / WebAssembly/binaryen
Change example tests to pass null for memory name
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
I see, right... a null is the best we could do, since we must still change the C API to add the new param either way. Sounds ok to leave null for later then.
Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r948317218
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the example tests that call the C API and inspect the arguments passed for the memory name. Update the relevant calls to pass null, then run those example tests and confirm they pass with the new argument.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, wasm
- Domain
- compilers, testing-qa
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100