WebAssembly / WebAssembly/binaryen
Add assertion to RemoveUnusedModuleElements
Open
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Should we add an assertion?
Originally posted by @tlively in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r938223951
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing RemoveUnusedModuleElements and the discussion linked from the issue, then check linked pull request #4983 to see the current state of the work. Confirm the intended invariant before deciding whether the assertion is still needed; done means the agreed assertion is added and the relevant validation passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100