WebAssembly / WebAssembly/binaryen
Add multi-memories assert to MemoryPacking
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Maybe we should put an assertion here so we don't forget about this.
Originally posted by @tlively in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r938221231
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the referenced discussion in pull request 4811 and locating MemoryPacking in the Binaryen source. Determine what multi-memory condition needs protection; done means an assertion covers that condition and the relevant existing checks still pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100