WebAssembly / WebAssembly/binaryen

Add comment of memory assumption to wasm-debug

Open
#4,925 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
WebAssembly
Stars
8.6k
Forks
885
Avg merge
1d 19h
Merged PRs (30d)
69

Description

Worth a comment here that we assume all memories have the same type (all 32 or all 64).

Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r933655909

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by finding the wasm-debug code associated with the linked pull request discussion and read the surrounding memory-type handling. Add a concise comment documenting the assumption that all memories share one type, either 32-bit or 64-bit. Done means the assumption is documented without changing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
wasm
Domain
compilers
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.