WebAssembly / WebAssembly/binaryen
Make readMemoryAccess() return value more explicit
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Does this return the memory index, or something else? Worth a comment here I think.
Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r933621856
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the readMemoryAccess() entry point and inspect what its return value represents. Add a comment that explicitly describes whether it returns a memory index or another value; the issue names no test or specific file, so verify the surrounding compiler code manually.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Documentation
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100