WebAssembly / WebAssembly/binaryen
Halt stack.h with an error if multi-memories are present
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
This pass can probably halt with an error (like on line 49 above) if there are no memories. Please also add a comment that we are assuming that memory 0 is the "main" memory here.
Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r933611134
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate stack.h and inspect the logic around the line 49 reference, including how it handles memory configuration. Confirm the requested unsupported-memory case halts with an error and document the assumption that memory 0 is the main memory; no test file is named in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100