WebAssembly / WebAssembly/binaryen
Add fatal errors to memory vector size checks
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
I wonder if we should produce a fatal error here (and in similar places) so we don't forget to come back and fix it up later. @kripken, wdyt?
Originally posted by @tlively in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r933629300
I agree that fatal errors are better in places like this.
Originally posted by @kripken in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r946951478
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the discussion from WebAssembly/binaryen pull request 4811, then locate the memory vector size checks referenced there and identify similar checks. The work is done when the relevant checks produce fatal errors consistently, including the similar places mentioned in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100