WebAssembly / WebAssembly/binaryen
Convert getMemoryOrNull to getMemory
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
Since we are producing a fatal error anyway, might as well call getMemory instead of getMemoryOrNull and skip the error checking here.
Originally posted by @tlively in https://github.com/WebAssembly/binaryen/pull/4811#discussion_r933621253
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository for getMemoryOrNull and inspect the caller where the fatal error is produced. Replace that call with getMemory and verify the surrounding error-checking path and relevant tests still behave as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- wasm
- Domain
- compilers
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100