WebAssembly / WebAssembly/binaryen
Dwarf tests fail on windows due to path seperators
Open
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
I noticed this when enabling windows testing as part of CI for the time in #2646.
--- D:\a\binaryen\binaryen\test\passes\class_with_dwarf_noprint.bin.txt
+++ actual
@@ -180,7 +180,7 @@
DW_AT_name [DW_FORM_strp] ( .debug_str[0x000000e5] = "rng1")
DW_AT_type [DW_FORM_ref4] (cu + 0x0037 => {0x00000037} "Random")
DW_AT_external [DW_FORM_flag_present] (true)
- DW_AT_decl_file [DW_FORM_data1] ("/tmp/emscripten_test_wasm3_2u9tontv/src.cpp")
+ DW_AT_decl_file [DW_FORM_data1] ("/tmp/emscripten_test_wasm3_2u9tontv\src.cpp")
DW_AT_decl_line [DW_FORM_data1] (23)
DW_AT_location [DW_FORM_exprloc] (DW_OP_addr 0x638)
May be worth fixing.. maybe not.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The failing fixture is test/passes/class_with_dwarf_noprint.bin.txt; start by reproducing the Dwarf test on Windows and compare the generated path with the POSIX output shown. Done means the test no longer differs only by path separators on Windows and still passes on non-Windows platforms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- compilers, operating-systems, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100