WebAssembly / WebAssembly/binaryen
Supporting up-to-date spec test format
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
I updated our spec test suite to up-to-date version in #2484, but there are numerous syntax that are not currently supported in Binaryen. So I triaged them into different categories and added them to spec test BLACKLIST in shared.py.
While it is not a goal of Binaryen to support every single syntax that are supported in the spec repo, it looks some of the unsupported syntax can be easily supported. And also there are files for which the reasons for failure are unknown, so they need triage.
I'd like to track the issue here. Help is welcome to fix any one of the issues listed there.
In the blacklist, 'stacky code' and 'binary module' wouldn't be easy to fix. Binaryen uses AST for the IR and currently does not support stacky code / notation, and Binaryen does not support binary modules for now. I think other things can be fixed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the spec test BLACKLIST in scripts/test/shared.py and review its categories and listed failure reasons. Choose one unsupported syntax that is not stacky code or a binary module, then trace the related spec test failure. Done means the syntax is supported and its entry can be removed from the blacklist.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100