WebAssembly / WebAssembly/binaryen
Asyncify lists use * as a wildcard, but function names can have *
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
The names are full C++ names, so e.g. void foo(int *x) is a valid name. We treat that * as a wildcard currently, which may mean more things are matched than expected.
One solution is to use something other than * as a wildcard, but that would be annoying. Another option is to have separate lists for patterns and for specific names perhaps.
cc @Beuc
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Asyncify's list handling and trace how full C++ names are matched against *. Compare wildcard matching with literal names containing *, then determine and document the intended behavior for both patterns and specific names. Done means names such as void foo(int *x) no longer cause unintended matches, with coverage for the relevant cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 32/100