WebAssembly / WebAssembly/binaryen
Change default inlining behavior to favor single-caller inlines
Nobody has claimed this yet.
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
See FIXMEs introduced in: https://github.com/WebAssembly/binaryen/pull/2125
Essentially, the check for calls == 1 need to be moved first in that function, otherwise oneCallerInlineMaxSize can never be bigger than flexibleInlineMaxSize, which naturally it would make sense for it to be.
@kripken mentioned this change can only be made after it has been checked if it doesn't regress size/speed.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the FIXME changes introduced by pull request 2125 and locate the inlining function containing the calls == 1 check. Verify the ordering change against size and speed measurements before considering the work done; the issue provides no specific test or benchmark file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, wasm
- Domain
- compilers, performance
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100