WebAssembly / WebAssembly/binaryen
testing with out-of-tree builds fails when running binaryen.js testcases
Open
Nobody has claimed this yet.
help wanted
- Dominant language
- WebAssembly
- Stars
- 8.6k
- Forks
- 885
- Avg merge
- 1d 19h
- Merged PRs (30d)
- 69
Description
STR:
- Build in an out-of-tree directory,
/out/of/tree. - Run
$CHECKOUT/check.py --binaryen-bin /out/of/tree/bin.
Expected results:
Tests run.
Actual results:
Most tests run, followed by:
[ checking binaryen.js testcases... ]
atomics.js
Traceback (most recent call last):
File "./check.py", line 632, in <module>
main()
File "./check.py", line 604, in main
run_binaryen_js_tests()
File "./check.py", line 362, in run_binaryen_js_tests
binaryen_js = open(os.path.join(options.binaryen_bin, 'binaryen.js')).read()
IOError: [Errno 2] No such file or directory: '/opt/build/froydnj/build-binaryen/bin/binaryen.js'
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in check.py, especially run_binaryen_js_tests(), and reproduce the command with --binaryen-bin pointing to an out-of-tree bin directory. Trace how the binaryen.js path is selected and verify the binaryen.js testcases complete successfully from that build layout.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, python, wasm
- Domain
- build-system, testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100