WebAssembly / WebAssembly/binaryen

auto-update problem on test/fib-dbg.wasm.fromBinary

Open
#1,040 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
WebAssembly
Stars
8.6k
Forks
885
Avg merge
1d 19h
Merged PRs (30d)
69

Description

Running ./auto_update_tests.py should be a no-op, but it breaks test/fib-dbg.wasm.fromBinary, changing it so that check.py fails. It creates this diff:

diff --git a/test/fib-dbg.wasm.fromBinary b/test/fib-dbg.wasm.fromBinary
index 3f940fa..307d880 100644
--- a/test/fib-dbg.wasm.fromBinary
+++ b/test/fib-dbg.wasm.fromBinary
@@ -124,21 +124,17 @@
   (local $var$9 i32)
   (local $var$10 i32)
   (local $var$11 i32)
-  ;;@ fib.c:8:0
   (block $label$0
    (set_local $var$11
     (get_global $global$3)
    )
-   ;;@ fib.c:3:0
    (set_local $var$6
     (i32.gt_s
      (get_local $var$0)
      (i32.const 0)
     )
    )
-   ;;@ fib.c:8:0
    (if
-    ;;@ fib.c:3:0
     (get_local $var$6)
     (block $label$1
      (set_local $var$1
@@ -155,23 +151,19 @@
      (set_local $var$4
       (i32.const 1)
      )
-     ;;@ fib.c:8:0
      (return
       (get_local $var$4)
      )
     )
    )
-   ;;@ fib.c:3:0
    (loop $label$3
     (block $label$4
-     ;;@ fib.c:4:0
      (set_local $var$3

Maybe missing a param or something in the auto-update script that is in check.py?

cc @yurydelendik , this is your code I believe.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with auto_update_tests.py and check.py, then inspect how test/fib-dbg.wasm.fromBinary is processed. Reproduce the issue with ./auto_update_tests.py and verify that the fixture remains unchanged and check.py passes afterward.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, wasm
Domain
compilers, testing-qa, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.