Incorrect workspace data in wf::view_change_workspace_signal
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 3.1k
- Forks
- 237
- Avg merge
- 1h 43m
- Merged PRs (30d)
- 1
Description
Describe the bug
The data returned by wf::view_change_workspace_signal is sometimes incorrect. This happens, for example, when we attempt to move a window using the with_win_* keybind of vswitch. I believe this happens when animations are involved. Or if you attempt to move a view between workspaces interactively, via the move plugin.
To Reproduce
Steps to reproduce the behavior:
- Enable plugin vswitch
- Move a view between two workspaces
- The signal
wf::view_change_workspace_signalcontains the same value in bothfromandtofields. Thetovalues is correct, and thefromvalue contains same value asto.
Expected behavior
from should contain the correct value.
Extra information
When the send_win_* vswitch is used, the values returned are proper.
Screenshots or stacktrace
N/A
Wayfire version
git
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the wf::view_change_workspace_signal entry point and the workspace-move paths used by the vswitch and move plugins, especially when animations are active. Reproduce the move with vswitch and compare the signal's from and to values; done means from reports the workspace the view actually left while to reports its destination.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100